impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3678: Fix migration of predicates into union operands with an order by + limit.
Date Fri, 08 Jul 2016 22:49:12 GMT
Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3600

Change subject: IMPALA-3678: Fix migration of predicates into union operands with an order
by + limit.
......................................................................

IMPALA-3678: Fix migration of predicates into union operands with an order by + limit.

There were two separate issues:

First, the SortNode incorrectly picked up unassigned conjuncts, and expected those to
be empty. In this case where predicates are migrated into union operands, there could
actually be unassigned conjuncts bound by the SortNode's tuple id (and so would be
incorrectly picked up). The fix is to not pick up unassigned conjuncts in the SortNode,
and allow them to be picked up later (into a SelectNode).

Second, when generating the plan for union operands we were missing a call to
graft a SelectNode on top of the operand plan to capture unassigned conjuncts.

Change-Id: I95d105ac15a3dc975e52dfd418890e13f912dfce
---
M fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java
M fe/src/main/java/com/cloudera/impala/planner/SortNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/union.test
3 files changed, 88 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/00/3600/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95d105ac15a3dc975e52dfd418890e13f912dfce
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>

Mime
View raw message