impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.
Date Fri, 29 Jul 2016 23:00:54 GMT
David Knupp has uploaded a new patch set (#6).

Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.
......................................................................

IMPALA-3898: Add a pytest skipif decorator based on presence of Impala
LZO.

As part of shoring up the build/test procedure for the ASF initiative,
if Impala LZO isn't present, we want to skip tests that would otherwise
fail without it. Rather than adding a bunch of pytest skip decorators
to existing tests, instead just create an autouse fixture in the
pytest conftest.py file. This fixture will automatically always get
invoked with any test, and in case ${IMPALA_LZO}/build/libimpalalzo.so
does not exist, it will skip tests where the test vector contains
compression_codec: lzo.

There is one query in data_errors (test_hdfs_scan_node_errors) that
will always fail without Impala LZO, regardless of codec, so it was
moved to a separate test, and in that one instance, a skipif decorator
was added.

Also, minor PEP-8 improvements were made in various files.

Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
---
A testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-lzo-node-errors.test
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
M tests/common/environ.py
M tests/conftest.py
M tests/data_errors/test_data_errors.py
5 files changed, 88 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/3782/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message