impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.
Date Fri, 29 Jul 2016 16:18:35 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.
......................................................................


Patch Set 1:

(2 comments)

Wow, this test is super confusing. I think over time it's gotten confused about what the test
is mean to do and what the test dimensions are.

http://gerrit.cloudera.org:8080/#/c/3782/1/tests/data_errors/test_data_errors.py
File tests/data_errors/test_data_errors.py:

PS1, Line 40: @SkipIfEnvironment.no_impalalzo
> So, just to double check, I rebuilt Impala both with and without Impala LZO
I looked at testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
and it's directly querying functional_text_lzo.bad_text_lzo

I think a better approach would be to split the lzo-dependent  tests in hdfs-scan-node-errors.test
out into a separate .test file and pytest method and then skip only that.


Line 46:     # Only run on delimited text with no compression.
> I think it might be. I found that test dimensions include vectors (am I usi
Yeah, seems like it's stale.


-- 
To view, visit http://gerrit.cloudera.org:8080/3782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message