impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3905: Add HdfsScanner::GetNext() interface and implementation for Parquet.
Date Fri, 29 Jul 2016 05:58:09 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3905: Add HdfsScanner::GetNext() interface and implementation for Parquet.
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3801/2/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 346:       return Status::OK();
> these seem like significant control flow changes (and i haven't looked at t
I'll ask Tim, but I don't think it's a significant change because we always transfer resources
in Close(), so there's no need to also transfer on eos.


http://gerrit.cloudera.org:8080/#/c/3801/4/be/src/exec/hdfs-parquet-scanner.h
File be/src/exec/hdfs-parquet-scanner.h:

Line 333:   virtual Status GetNext(RowBatch* row_batch, bool* eos) {
> alternatively, put this GetNext with body into the base class and make GetN
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab50770bac05afcda4d3404fb4f53a0104931eb0
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message