impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3905: Add HdfsScanner::GetNext() interface and implementation for Parquet.
Date Fri, 29 Jul 2016 01:25:54 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3905: Add HdfsScanner::GetNext() interface and implementation for Parquet.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3801/2/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 302: Status HdfsParquetScanner::GetNext(RowBatch* row_batch, bool* eos) {
> hm, it would still be nice to check that if this is getting called from out
Done. Added a GetNextInternal().


http://gerrit.cloudera.org:8080/#/c/3801/2/be/src/exec/hdfs-scanner.h
File be/src/exec/hdfs-scanner.h:

Line 109:   /// If 'add_batches_to_queue' is true the caller most use ProcessSplit() and not
> must (call)
Done


Line 132:   /// This function should only return on error or end of scan range.
> you can't call this if add_batches_to_queue was false, right? point that ou
Added comments and DCHECKs.


-- 
To view, visit http://gerrit.cloudera.org:8080/3801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab50770bac05afcda4d3404fb4f53a0104931eb0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message