impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1731,IMPALA-3868: Float values are not parsed correctly
Date Thu, 28 Jul 2016 23:28:33 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3791/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS2, Line 2796:   TestValue("CAST('  inf  ' AS FLOAT)", TYPE_FLOAT,
              :       numeric_limits<float>::infinity());
              :   TestValue("CAST('  inf  ' AS DOUBLE)", TYPE_DOUBLE,
              :       numeric_limits<double>::infinity());
> This doesn't seem to match what you wrote in the comment. Isn't leading whi
Nevermind. Looks like the leading whitespace is removed before calling StringToFloatInternal().


-- 
To view, visit http://gerrit.cloudera.org:8080/3791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message