impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3861: Fix BetweenPredicate.clone() to preserve Expr reference structure.
Date Thu, 28 Jul 2016 22:49:04 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-3861: Fix BetweenPredicate.clone() to preserve Expr reference structure.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3804/2/fe/src/main/java/com/cloudera/impala/analysis/BetweenPredicate.java
File fe/src/main/java/com/cloudera/impala/analysis/BetweenPredicate.java:

PS2, Line 132: private void setRewrittenPredicate()
Where is this function used?


http://gerrit.cloudera.org:8080/#/c/3804/2/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeSubqueriesTest.java
File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeSubqueriesTest.java:

PS2, Line 487: AnalyzesOk
Why in comments and not an AnalysisError?


http://gerrit.cloudera.org:8080/#/c/3804/2/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test
File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test:

PS2, Line 1846: t2.test_id between t1.tinyint_col and t1.int_col
Can you also add one or more cases with more "interesting" exprs in the between? e.g. casts,
arithmetic exprs


-- 
To view, visit http://gerrit.cloudera.org:8080/3804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0838b30444ed9704ce6a058d30718a24caa7444a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: Yes

Mime
View raw message