impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] CDH-41931: Toolchain for Ubuntu16 Impala builds
Date Wed, 27 Jul 2016 23:54:06 GMT
Matthew Jacobs has posted comments on this change.

Change subject: CDH-41931: Toolchain for Ubuntu16 Impala builds
......................................................................


Patch Set 1:

(1 comment)

How about the change to use the cmake from the toolchain?

http://gerrit.cloudera.org:8080/#/c/3800/1/be/src/runtime/raw-value.inline.h
File be/src/runtime/raw-value.inline.h:

Line 22: #include <math.h>
can you move this above the boost include? I found that the order mattered in at least one
case. I think it's OK to put std lib includes above other libraries. You can put an extra
blank line between them to indicate its a different group.


-- 
To view, visit http://gerrit.cloudera.org:8080/3800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message