impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3201: HEADER ONLY: buffer pool
Date Tue, 26 Jul 2016 23:30:29 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3201: HEADER ONLY: buffer pool
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3688/2/be/src/bufferpool/buffer-pool.h
File be/src/bufferpool/buffer-pool.h:

Line 303:   uint8_t* buf() const;
PageHandle should not have this function. all access of the underlying data needs to go through
the buffer abstraction (otherwise you don't really have a separation of abstractions).

algorithms that only implement data processing logic should only deal with buffers, whereas
algorithms that only implement spilling-type logic should only deal with pages.


-- 
To view, visit http://gerrit.cloudera.org:8080/3688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message