impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2700: ASCII NUL characters are doubled on insert into text tables
Date Tue, 26 Jul 2016 22:42:47 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2700: ASCII NUL characters are doubled on insert into text tables
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3703/5//COMMIT_MSG
Commit Message:

PS5, Line 9: Currently the scanner processes the '\0' character as a no special character
           : whereas the writer treats it as a special character. The writer
           : appends a special character before writting which is causing the ASCII
           : NULL characters to double since they are the default escape characters.
           : This adds a check to treat '\0' as a no special character in the
           : writter.
This is confusing.  Is the following accurate?

The when the escape char is set to '\0', the scanner threads this as no escape.  However,
the text writer currently treats '\0' as a valid escape character, and escape it when writing,
causing a doubling of ASCII NUL characters.

The fix is to make the text writer treat escape char of '\0' as no escape.


-- 
To view, visit http://gerrit.cloudera.org:8080/3703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia30fa314d1ee1e99f9e7598466eb1570ca7940fc
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message