impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2347: Reuse metastore client connections in Catalog
Date Tue, 26 Jul 2016 20:37:36 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-2347: Reuse metastore client connections in Catalog
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

Nice!

http://gerrit.cloudera.org:8080/#/c/3381/8/fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java
File fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java:

Line 54:   private HiveMetaHookLoader dummyHookLoader = new HiveMetaHookLoader() {
make it final?


-- 
To view, visit http://gerrit.cloudera.org:8080/3381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message