impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3864: qgen: reduce likelihood of create query() exceptions
Date Thu, 21 Jul 2016 17:05:28 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-3864: qgen: reduce likelihood of create_query() exceptions
......................................................................


Patch Set 1:

(1 comment)

Will probably take a look at this one in smaller chunks. This is just an immediate observation.

http://gerrit.cloudera.org:8080/#/c/3720/1/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

PS1, Line 1473:   from model_translator import SqlWriter
              : 
              :   NUM_TABLES = 5
              :   NUM_COLS_EACH_TYPE = 10
              :   NUM_QUERIES = 3000
I'd expect to find these at the top of the file. Why here?


-- 
To view, visit http://gerrit.cloudera.org:8080/3720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd9434a92973176aefb99e11e039209cac3cea65
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message