impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page
Date Wed, 20 Jul 2016 23:36:09 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3716: Add Memory Tab in query's Details page
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3664/4/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

PS4, Line 263:      
> I think the indent is counted from the first letter of "else",
no, it's counted from the }, i.e. the first character on the previous line.


-- 
To view, visit http://gerrit.cloudera.org:8080/3664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message