impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3886: Improve log of pip download.py
Date Wed, 20 Jul 2016 15:28:23 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3886: Improve log of pip_download.py
......................................................................


Patch Set 1:

(1 comment)

Thanks for the review, uploaded PS2.

http://gerrit.cloudera.org:8080/#/c/3687/1/infra/python/deps/pip_download.py
File infra/python/deps/pip_download.py:

PS1, Line 62: print "Matching md5sum, skipping %s" % filename
> Just add "already exists" as well, so it's clear why it's being skipped.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d81743814be37ee8ddbe04c264ed2bf37410f9
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message