impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks
Date Wed, 20 Jul 2016 00:50:47 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3282/11/be/src/util/stopwatch.h
File be/src/util/stopwatch.h:

Line 241:   ScopedStopWatch(T* sw, bool enabled = true) :
> If you used ScopedStopWatch directly it would still be useful in any situat
I was thinking along the lines of a more straightforward solution to the specific problem
this is trying to solve in blocking-join-node.cc. The following seems simpler and less invasive:

if (ASYNC_BUILD) built_probe_overlap_stop_watch_.Start();
// Do the work here
if (ASYNC_BUILD) built_probe_overlap_stop_watch_.Stop();

It's not clear we're going to need this conditional timer in many other places, so I'd prefer
the straightforward solution.


-- 
To view, visit http://gerrit.cloudera.org:8080/3282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d7608181eeacfe706a09c1e153d0a3e1ee9b475
Gerrit-PatchSet: 11
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message