impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathy Sun (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page
Date Tue, 19 Jul 2016 21:26:09 GMT
Kathy Sun has posted comments on this change.

Change subject: IMPALA-3716: Add Memory Tab in query's Details page
......................................................................


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/3664/3/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

PS3, Line 249:                server_->GetQueryExecState(unique_id, true);
> indent by four chars only
Done


Line 254:       lock_guard<mutex> l(*exec_state->lock(), adopt_lock_t());
> Also there's 4 spaces indent here instead of 2.
Done


PS3, Line 256: const string& err = Substitute("Invalid query id: $0", PrintId(unique_id));
             :         Value json_error(err.c_str(), document->GetAllocator());
> When you click on this tab with a finished query, won't it just show the er
At current patch,
for finished query, there still is a tab, but will shows “not Available”message in line
264.

More specifically,
if exec_state is destroyed, we can know query is finished.-- show a friendly message.
if exec_state is still active, but coordinator is NULL, I use the generic error message template,
I'm not sure it's reasonable...


PS3, Line 254:     lock_guard<mutex> l(*exec_state->lock(), adopt_lock_t());
             :       if (exec_state->coord() == NULL) {
             :         const string& err = Substitute("Invalid query id: $0", PrintId(unique_id));
             :         Value json_error(err.c_str(), document->GetAllocator());
             :         document->AddMember("error", json_error, document->GetAllocator());
             :         return;
             :       }
             :       MemTracker* query_mem_tracker = exec_state->coord()->query_mem_tracker();
             :       mem_usage_text = query_mem_tracker->LogUsage();
> indentation should be two chars here
Done


Line 264:       mem_usage_text = "The query is finished, current memory consumption is not
available.";
> 4 spaces indent
Done


Line 264:       mem_usage_text = "The query is finished, current memory consumption is not
available.";
> Missed the long line here. Should be 90 characters or less.
Hi Tim, What do you mean by “miss the long line”?


PS3, Line 270:       d
> fix indentation
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Kathy Sun <kathy.sun@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message