impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Add Chef recipes for preparing an Impala dev machine
Date Sat, 16 Jul 2016 00:48:29 GMT
Jim Apple has posted comments on this change.

Change subject: Add Chef recipes for preparing an Impala dev machine
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3597/3/dev_tools/cookbooks/impala/attributes/default.rb
File dev_tools/cookbooks/impala/attributes/default.rb:

Line 4: # All rights reserved - Do Not Redistribute
Can you make sure the headers for the files now have apache headers like the .cc files in
in be/src?

Some files still have "Do Not Redistribute" or "Do Not Distribute".


http://gerrit.cloudera.org:8080/#/c/3597/1/dev_tools/cookbooks/impala/recipes/lzo.rb
File dev_tools/cookbooks/impala/recipes/lzo.rb:

Line 12: #     http://www.apache.org/licenses/LICENSE-2.0
> TBD
Can you file a JIRA for this todo?


-- 
To view, visit http://gerrit.cloudera.org:8080/3597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0699b7202eee3994c18b7bb13ed298e506cd615b
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message