impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3376: Extra definition level when writing Parquet files
Date Fri, 15 Jul 2016 22:34:19 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3376: Extra definition level when writing Parquet files
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3556/2/be/src/util/parquet-reader.cc
File be/src/util/parquet-reader.cc:

Line 149: void CheckDataPage(const ColumnChunk& col, const PageHeader& header, uint8_t*
data) {
> This looks odd to me, I think C++ requires constant array sizes for arrays 
Done


http://gerrit.cloudera.org:8080/#/c/3556/2/tests/query_test/test_writers.py
File tests/query_test/test_writers.py:

Line 48:     try:
> If this fails you'll leak the temporary directory. Move this line into the 
Done


Line 50: 
> This will not recurse into subdirectories. If hdfs_parquet_table_writer doe
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cafd7ef6b607ce6f815072b8af7395a892704d9
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message