impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3756: Fix wrong argument type in HiveStringsTest
Date Fri, 15 Jul 2016 21:42:45 GMT
Hello Bharath Vissapragada,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3617

to look at the new patch set (#6).

Change subject: IMPALA-3756: Fix wrong argument type in HiveStringsTest
......................................................................

IMPALA-3756: Fix wrong argument type in HiveStringsTest

One of the tests in HiveStringsTest passed Text as input argument
to TestHiveUdf() instead of String. It worked fine if the argument
of UDFLength.evaluate() is of type Text but that doesn't seem to be
the case in code coverage build. The fix is to call TestHiveUdf()
with String and lets it cast the argument to the right type based
on the signature of the UDF method. A test-only UdfExecutor ctor
is also removed so we can exercise the actual ctor used by JNI calls
from the BE.

Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e
---
M fe/src/main/java/com/cloudera/impala/hive/executor/UdfExecutor.java
M fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java
2 files changed, 81 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/17/3617/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message