impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3756: Fix wrong argument type in HiveStringsTest
Date Fri, 15 Jul 2016 09:24:28 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3756: Fix wrong argument type in HiveStringsTest
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3617/5/fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java
File fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java:

PS5, Line 235: null
Does it work with null? Please ignore if it does. Else I think it can be "default".


PS5, Line 237: TFunction fn = scalar_fn.toThrift()
nit:Remove and directly call scalar_fn.toThrift() below? Seems like we are not using anywhere
else.


-- 
To view, visit http://gerrit.cloudera.org:8080/3617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message