impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1731: StringToFloatInternal() does not handle inf correctly
Date Wed, 13 Jul 2016 22:48:09 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-1731: StringToFloatInternal() does not handle inf correctly
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3622/1/be/src/util/string-parser.h
File be/src/util/string-parser.h:

PS1, Line 422:       } else if (s[i] == '.') {
             :         decimal = true;
> Not your change but I just noticed that we treat cast("2.3....3" as float) 
I meant cast("2.3....3" as float) is treated the same as cast("2.33" as float). This is probably
a bug.


-- 
To view, visit http://gerrit.cloudera.org:8080/3622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message