impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3610: Account for memory used by filters in the coordinator
Date Wed, 13 Jul 2016 05:46:45 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3610: Account for memory used by filters in the coordinator
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3618/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

PS1, Line 2077: query_mem_tracker
for IMPALA-3647 we track the filters in the bank under a separate memtracker. we should probably
do the same here, no?


Line 2092:           state->bloom_filter.reset(new BloomFilter(params.bloom_filter));
why do we always do TryConsume() if this is the only path that actually needs to allocate
the memory?  Or is there some other memory allocation that I'm not noticing?


-- 
To view, visit http://gerrit.cloudera.org:8080/3618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message