impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3159: impala-shell does not accept wildcard or SAN certificates
Date Tue, 12 Jul 2016 21:52:03 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN certificates
......................................................................


Patch Set 4:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/3615/4/be/src/testutil/bad-cert.key
File be/src/testutil/bad-cert.key:

Line 1: -----BEGIN RSA PRIVATE KEY-----
Can you add a text file to this directory listing what every key / cert file contains?


http://gerrit.cloudera.org:8080/#/c/3615/4/shell/TSSLSocketWithWildcardSAN.py
File shell/TSSLSocketWithWildcardSAN.py:

Line 24: class TSSLSocketWithWildcardSAN(TSSLSocket.TSSLSocket):
needs a class comment


http://gerrit.cloudera.org:8080/#/c/3615/4/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:

PS4, Line 37: \
nit: just for neatness, consider enclosing these in parentheses. Then I don't think you need
the line continuation marker:

  ("--flag1"
   "--flag2")


Line 57:     self._verify_simple_query()
negative cases here as well?


PS4, Line 112: incorrect
Is it an incorrect cert, or a badly formatted one? If it's the former, "bad-cert.pem" is misleading.


PS4, Line 112: a
an


PS4, Line 121: _verify_simple_query
_validate_positive_cases()?


Line 127:       assert msg in result.stderr
for completeness, add a test that confirms this works when just --ssl is specified (to mirror
the negative cases)


-- 
To view, visit http://gerrit.cloudera.org:8080/3615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8908f05afe4a6da9713fd303c499c50f692985ef
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message