impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3817: Ensure filter hash function is the same on all hardware.
Date Tue, 12 Jul 2016 17:07:40 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware.
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

I wonder why this was done in the first place if it hash no perf benefit...

http://gerrit.cloudera.org:8080/#/c/3566/1//COMMIT_MSG
Commit Message:

Line 13: 
please also mention that this impacts DataStreamMgr's hash function, but that that also doesn't
show a perf differences.


http://gerrit.cloudera.org:8080/#/c/3566/1/be/src/runtime/raw-value.inline.h
File be/src/runtime/raw-value.inline.h:

Line 210: 
let's add a comment saying the choice of hash function needs to be consistent across all hosts
of the cluster.


-- 
To view, visit http://gerrit.cloudera.org:8080/3566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09b67f9e987af3e2c8ac12c347b95a7e09ce6fa
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message