impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3756: Fix wrong argument type in HiveStringsTest
Date Tue, 12 Jul 2016 03:50:51 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3756: Fix wrong argument type in HiveStringsTest
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3617/1/fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java
File fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java:

Line 339:     TestHiveUdf(UDFLength.class, createInt(5), "Hello");
> As discussed offline, I think there is actually a real bug hidden here. I t
I think we should fix the evaluate() lookup logic based on the input types  given to the UdfExecutor.init().
Currently the input is of type "Type" which is ambiguous because multiple JavaUdfDataTypes
map to it. Instead if we have the actually type (or something similar), we can do a better
lookup of the function. In this particular case [1], both the evaluate methods are treated
as the same because they map to the same PrimitiveType. 

[1] https://github.com/cloudera/hive/blob/cdh5-1.1.0_5.7.0/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLength.java


-- 
To view, visit http://gerrit.cloudera.org:8080/3617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message