impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext
Date Sat, 09 Jul 2016 01:04:25 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3590/4/be/src/exec/hdfs-text-scanner.cc
File be/src/exec/hdfs-text-scanner.cc:

Line 194:     scan_node_->RangeComplete(THdfsFileFormat::TEXT, compression_type);
is it important that RangeComplete() is called after AddFinalRowBatch(), or could we just
move all of this code up?


-- 
To view, visit http://gerrit.cloudera.org:8080/3590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message