impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext
Date Fri, 08 Jul 2016 23:31:19 GMT
Hello Dan Hecht, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3590

to look at the new patch set (#4).

Change subject: IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext
......................................................................

IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext

Each scanner context has at least one stream which corresponds to
a scan range. For parquet scanner, there can be multuple streams.
These Stream objects are stored in the RuntimeState's object pool
even though they have the same life span of the scanner threads.
This change makes ScannerContext the owner of the Stream objects
so they will be freed when ScannerContext is destoryed.

Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045
---
M be/src/exec/hdfs-scanner.cc
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/scanner-context.cc
M be/src/exec/scanner-context.h
4 files changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/90/3590/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message