impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3727: Change microbenchmarks to use percentile-based reporting
Date Fri, 08 Jul 2016 22:45:05 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3727: Change microbenchmarks to use percentile-based reporting
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

I think we should add median (50% percentile) as discussed.

http://gerrit.cloudera.org:8080/#/c/3579/2/be/src/util/benchmark.cc
File be/src/util/benchmark.cc:

PS2, Line 118: h-4
missing spaces around - here and 3 lines below


-- 
To view, visit http://gerrit.cloudera.org:8080/3579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa35789922e5019fbb77b0737c9ea19df038e3b
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message