impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3677: Write minidump on SIGUSR1
Date Thu, 07 Jul 2016 22:46:02 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3677: Write minidump on SIGUSR1
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3312/3/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

PS3, Line 149: time.sleep(5)
> Oops -- sorry! I didn't see Tim's comment. If there's consensus that adding
I added a timed loop in PS5. It was a bit of a hassle, as the breakpad forks to write minidumps
on request, so there were extra processes in the way, even when the files had already started
to show up. I ended up waiting on the number or processes instead, and found IMPALA-3898 on
the way. :)


-- 
To view, visit http://gerrit.cloudera.org:8080/3312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40149e48e391451de21a5c8bda18e2307fc89513
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message