impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3734: C++11 - Replace boost:shared ptr with std:: equivalent
Date Thu, 07 Jul 2016 21:09:06 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3734: C++11 - Replace boost:shared_ptr with std:: equivalent
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3563/3/be/src/runtime/test-env.cc
File be/src/runtime/test-env.cc:

Line 23: using boost::scoped_ptr;
why?


http://gerrit.cloudera.org:8080/#/c/3563/3/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

Line 593:   shared_ptr<SessionState> state = make_shared<SessionState>();
does this have any advantage over the c'tor?


http://gerrit.cloudera.org:8080/#/c/3563/3/be/src/transport/TSaslServerTransport.h
File be/src/transport/TSaslServerTransport.h:

Line 178:     TransportMap transportMap_;
needed?


-- 
To view, visit http://gerrit.cloudera.org:8080/3563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b52ec7167999d6ac1d1c56a0ee9cef52dc1615e
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message