impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata()
Date Thu, 07 Jul 2016 17:10:59 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata()
......................................................................


Patch Set 21:

> > What I remember from last night was the GIT_COMMIT_HASH of that
 > > build was c1a1762d00c14fa9d623a1d85918fbd0e1dc3c77 which is the
 > > commit hash of patch set 20. That's also the commit hash in your
 > > pasted output. That is derived from a local git rev-parse of your
 > > current IMPALA_HOME. This leads me to believe your IMPALA_HOME
 > was
 > > c1a1762d00c14fa9d623a1d85918fbd0e1dc3c77 at the time of running
 > > gerrit-verify-merge.
 > >
 > > I will investigate the confusing issue of the refspec printed
 > being
 > > 21.
 > 
 > I just checked the console output. The job was indeed build on
 > commit adea2350e2ad9e8e50db7ae86caa1d2502aeface not my local commit
 > since I rebased on Gerrit UI (this is what I used to do).
 > 
 > So Jenkins failed to find the correct commit that it actually built
 > on. right?
 > 
 > + git fetch --depth=1 https://gerrit.cloudera.org/Impala
 > refs/changes/71/3371/21
 > From https://gerrit.cloudera.org/Impala
 > * branch            refs/changes/71/3371/21 -> FETCH_HEAD
 > + git rev-parse FETCH_HEAD
 > adea2350e2ad9e8e50db7ae86caa1d2502aeface

and from the console output:
HEAD is now at adea235... IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata()

-- 
To view, visit http://gerrit.cloudera.org:8080/3371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14
Gerrit-PatchSet: 21
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message