impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.
Date Wed, 06 Jul 2016 12:03:31 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-1654: Support general predicates in most partition DDL operations.
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/1563/7//COMMIT_MSG
Commit Message:

Line 39: // we can also do 'or'
And 'not'? All binary predicates, like regex matching?


http://gerrit.cloudera.org:8080/#/c/1563/6/testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
File testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test:

Line 316: compute incremental stats incremental_null_part_key partition(p is NULL);
What could we do to ensure this doesn't break?

Breaking syntax should happen rarely:

1. Major versions ("3.0", not "2.8")

2. Very rarely used and was a mistake to begin with

3. We are backed into a corner with no way out


-- 
To view, visit http://gerrit.cloudera.org:8080/1563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Amos Bird <amosbird@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Amos Bird <amosbird@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message