impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Youwei Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()
Date Wed, 06 Jul 2016 08:38:31 GMT
Youwei Wang has posted comments on this change.

Change subject: IMPALA-889: Add support for ISO-SQL trim()
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3213/7//COMMIT_MSG
Commit Message:

PS7, Line 9: ISO-SQL compliant
> This doesn't look ISO-SQL compliant. Looking at the standard links you prov
Hi Jim. 
It is easy to adjust the order of parameters to follow these: "$where", "$characters" and
"$string_to_be_trimmed" like:
select trim(option, chars_to_trim, source_string);
(Previous syntax follows the request of one customer who proposes this JIRA.)

As you can see there exists a SQL keyword "FROM" for the standard SQL. So if you want to follow
such ISO-SQL standard very strictly, I am afraid we should modify the Impala SQL parser and
not just simply add a UDF here. 

Would you please share your idea about this? Thank you :)


http://gerrit.cloudera.org:8080/#/c/3213/7/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 2009:   /// Normal cases with different forms of the "option" argument
> Can you break this into secions with a short comment describing what each s
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <youwei.a.wang@intel.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Youwei Wang <youwei.a.wang@intel.com>
Gerrit-HasComments: Yes

Mime
View raw message