impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3442: Replace '> >' with '>>' in template decls
Date Tue, 05 Jul 2016 01:53:15 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3442: Replace '> >' with '>>' in template decls
......................................................................


Patch Set 1:

This confuses emacs's c++ mode.

I also think it is not strictly required by our C++ guide, which is basically Google's with
some slight modifications.

-- 
To view, visit http://gerrit.cloudera.org:8080/3562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b27dfbda791ec6730c329c91bed015887a5e27c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message