impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata()
Date Fri, 01 Jul 2016 17:49:48 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata()
......................................................................


Patch Set 15:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3371/15/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java
File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java:

PS15, Line 74:  * Null pattern's matching is controlled by 'isNullMatchAll', where if it is
set then
             :    * null matches everything; unset otherwise.
We should be able to eliminate this parameter. Users of this API should always pass in a correct
pattern. Since the caller will know if nulls should match all or not, they can do something
like:

  // If nulls should match all
  createJdbcPatternMatcher(pattern == null ? : PatternMatcher.MATCH_ALL_PATTERN : pattern);

  // If nulls should match none
  createJdbcPatternMatcher(pattern = null ? PatternMatcher.MATCH_NONE_PATTERN : pattern);


PS15, Line 78: isNullMatchAll
can you point out where this is set to true?


-- 
To view, visit http://gerrit.cloudera.org:8080/3371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14
Gerrit-PatchSet: 15
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message