Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201606292009.u5TK9LPe026205@ip-10-146-233-104.ec2.internal>
Date: Wed, 29 Jun 2016 20:09:21 +0000
From: "Huaisi Xu (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, dev@impala.incubator.apache.org
CC: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Reply-To: hxu@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3711=3A_Remove_unnecessary_privilege_checks_in_getDbsMetadata=28=29=0A?=
In-Reply-To: <gerrit.1465605484000.I17d8c5b9fb12483e4b01b819fba48b6849311a14@gerrit.cloudera.org>
References: <gerrit.1465605484000.I17d8c5b9fb12483e4b01b819fba48b6849311a14@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 29 Jun 2016 20:09:27 -0000

Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata()
......................................................................


Patch Set 11:

(9 comments)

sorry was having a team lunch.

http://gerrit.cloudera.org:8080/#/c/3371/11//COMMIT_MSG
Commit Message:

PS11, Line 9: suffers
> suffered
Done


PS11, Line 15: . As a result, even though
             : user wants nothing, we ended up checking everything.
> "thereby causing unnecessary privilege checks for catalog objects that aren
Done


PS11, Line 18: This patch changes getDbsMetadata()'s interface such that
             : caller can pass addition information and it knows whether
             : pattern is provided or not. This patch also applies filters
             : before checks any privilege.
> Maybe we can refine it a bit. How about something like "This patch modifies
Done


http://gerrit.cloudera.org:8080/#/c/3371/11/fe/src/main/java/com/cloudera/impala/catalog/Catalog.java
File fe/src/main/java/com/cloudera/impala/catalog/Catalog.java:

PS11, Line 325: String
> nit: Strings
Done


http://gerrit.cloudera.org:8080/#/c/3371/11/fe/src/main/java/com/cloudera/impala/service/Frontend.java
File fe/src/main/java/com/cloudera/impala/service/Frontend.java:

PS11, Line 597: if (matcher == null) return Collections.emptyList();
> Is there a reason why we can't push that check into the catalog.getTableNam
I did not think much about this.. for me it is the same. another reason I just thought of is that we cannot do that in getColumns() since it matches everything itself. So the idea maybe catalog.java does not take null matcher?

I can definitely move that if you insist.


PS11, Line 642: if (matcher == null) return Collections.emptyList();
> Same comment as above.
see above


http://gerrit.cloudera.org:8080/#/c/3371/11/fe/src/main/java/com/cloudera/impala/service/MetadataOp.java
File fe/src/main/java/com/cloudera/impala/service/MetadataOp.java:

Line 226:    * Utility Class that represents the input parameters of getDbsMetadata() function call.
> "a"
Done


http://gerrit.cloudera.org:8080/#/c/3371/11/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java
File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java:

PS11, Line 34: pattern_
> typo: patterns_
Done


http://gerrit.cloudera.org:8080/#/c/3371/11/testdata/workloads/functional-query/queries/QueryTest/show.test
File testdata/workloads/functional-query/queries/QueryTest/show.test:

PS11, Line 157: This behaves different than Hive, see IMPALA-3744
> "# Impala only considers '*' and '|' as meta-characters in SHOW statements 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14
Gerrit-PatchSet: 11
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes