Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201606291624.u5TGOMPX020098@ip-10-146-233-104.ec2.internal>
Date: Wed, 29 Jun 2016 16:24:22 +0000
From: "Michael Brown (Code Review)" <gerrit@cloudera.org>
To: Bharath Vissapragada <bharathv@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: David Knupp <dknupp@cloudera.com>, Dan Hecht <dhecht@cloudera.com>
Reply-To: mikeb@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3680=3A_Cleanup_the_scan_range_state_after_failed_hdfs_cache_reads=0A?=
In-Reply-To: <gerrit.1465212188000.I0a9ea19dd8571b01d2cd5b87da1c259219f6297a@gerrit.cloudera.org>
References: <gerrit.1465212188000.I0a9ea19dd8571b01d2cd5b87da1c259219f6297a@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 29 Jun 2016 16:24:30 -0000

Michael Brown has posted comments on this change.

Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3313/8/tests/query_test/test_hdfs_caching.py
File tests/query_test/test_hdfs_caching.py:

PS8, Line 101:     if self.exploration_strategy() != 'exhaustive': pytest.skip()
Unfortunately this means this test won't ever be run, because the workload is not set to functional-query, and for historical reasons not clear to me, the way we call impala-py.test is only to set the workload exploration strategy of the functional-query workload (see bin/run-all-tests.sh, L89-90).


PS8, Line 121:       while not is_path_fully_cached(encrypted_table_dir): time.sleep(2)
What about a max timeout here so we don't loop indefinitely?


-- 
To view, visit http://gerrit.cloudera.org:8080/3313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a9ea19dd8571b01d2cd5b87da1c259219f6297a
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes