Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201606251409.u5PE96mh014885@ip-10-146-233-104.ec2.internal>
Date: Sat, 25 Jun 2016 14:08:58 +0000
From: "Youwei Wang (Code Review)" <gerrit@cloudera.org>
To: Youwei Wang <youwei.a.wang@intel.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Jim Apple <jbapple@cloudera.com>
Reply-To: youwei.a.wang@intel.com
Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-889=3A_Add_support_for_ISO-SQL_trim=28=29=0A?=
In-Reply-To: <gerrit.1464166711000.I4753c608b0b00569bf8c5e95b132df6df358e602@gerrit.cloudera.org>
References: <gerrit.1464166711000.I4753c608b0b00569bf8c5e95b132df6df358e602@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Sat, 25 Jun 2016 14:09:13 -0000

Youwei Wang has uploaded a new patch set (#7).

Change subject: IMPALA-889: Add support for ISO-SQL trim()
......................................................................

IMPALA-889: Add support for ISO-SQL trim()

Add support for an ISO-SQL compliant trim() function.
Syntax: select trim(source_string, chars_to_trim, option);
source_string: the source string to trim;
chars_to_trim: the characters to trim, which is represented as a string;
option: enumerate values, available choices are: left/right/both:
  left means trimming characters from the start of the source string;
  right means trimming characters from the end of the source string;
  both means trimming characters from both ends of the source string;
Note: option is case-insensitive, which means 'left' equals 'LeFt'.
Example:
  select btrim('abc%%defg%%%%%', 'a%', 'left'); returns 'bc%%defg%%%%%';
  select btrim('abc%%defg%%%%%', 'fg%', 'right'); returns 'abc%%de';
  select btrim('abc%%defg%%%%%', 'ab%', 'leading'); returns 'c%%defg%%%%%';
  select btrim('abc%%defg%%%%%', 'bfg%', 'trailing'); returns 'abc%%de';
  select btrim('abc%%defg%%%%%', 'abfg%', 'both'); returns 'c%%de';

Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602
---
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
4 files changed, 138 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/13/3213/7
-- 
To view, visit http://gerrit.cloudera.org:8080/3213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <youwei.a.wang@intel.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Youwei Wang <youwei.a.wang@intel.com>