Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201606171027.u5HARD0c020712@ip-10-146-233-104.ec2.internal>
Date: Fri, 17 Jun 2016 10:27:13 +0000
From: "Bharath Vissapragada (Code Review)" <gerrit@cloudera.org>
To: Huaisi Xu <hxu@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>,
        Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>,
        Dan Hecht <dhecht@cloudera.com>, Juan Yu <jyu@cloudera.com>
Reply-To: bharathv@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3687=3A_Prefer_Avro_field_name_during_schema_reconciliation=0A?=
In-Reply-To: <gerrit.1465339965000.Ia3e43b2885853c2b4f207a45a873c9d7f31379cd@gerrit.cloudera.org>
References: <gerrit.1465339965000.Ia3e43b2885853c2b4f207a45a873c9d7f31379cd@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Fri, 17 Jun 2016 10:27:19 -0000

Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3687: Prefer Avro field name during schema reconciliation
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3331/6/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java
File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java:

Line 136:       // as a CHAR/VARCHAR/STRING in the reconciled schema. Column name and comment
> Just my two cents. Why don't we just throw an error if they are inconsisten
I discussed this with Alex in the past. From what I understand all this reconciliation logic was done to be consistent with Hive (although there are quite a few rough edges). May be he can give more context once he is back from vacation.


-- 
To view, visit http://gerrit.cloudera.org:8080/3331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-HasComments: Yes