Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CAA0E200B29 for ; Thu, 16 Jun 2016 05:21:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C97F5160A57; Thu, 16 Jun 2016 03:21:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1FD8A160A4D for ; Thu, 16 Jun 2016 05:21:10 +0200 (CEST) Received: (qmail 22651 invoked by uid 500); 16 Jun 2016 03:21:09 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 22640 invoked by uid 99); 16 Jun 2016 03:21:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jun 2016 03:21:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F13C9C0200 for ; Thu, 16 Jun 2016 03:21:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SfyMqWdlLD4w for ; Thu, 16 Jun 2016 03:21:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0EDDE5F295 for ; Thu, 16 Jun 2016 03:21:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u5G3L6of032449; Thu, 16 Jun 2016 03:21:06 GMT Message-Id: <201606160321.u5G3L6of032449@ip-10-146-233-104.ec2.internal> Date: Thu, 16 Jun 2016 03:21:06 +0000 From: "Dimitris Tsirogiannis (Code Review)" To: Huaisi Xu , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Alex Behm , Dan Hecht , Bharath Vissapragada Reply-To: dtsirogiannis@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3687=3A_Prefer_Avro_field_name_during_schema_reconciliation=0A?= X-Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd X-Gerrit-ChangeURL: X-Gerrit-Commit: b29f36fd0d216394812ebedd8bcad8e38e200da3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 16 Jun 2016 03:21:12 -0000 Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3687: Prefer Avro field name during schema reconciliation ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3331/5/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: PS5, Line 119: AnalysisException > not sure how to comment.. analyze() can throw but I think it should have a In the context of this particular function, what is interesting is that an AnalysisException can now be thrown if we fail to analyze a reconciled column definition for a String type, no? -- To view, visit http://gerrit.cloudera.org:8080/3331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Huaisi Xu Gerrit-HasComments: Yes