Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7159F200AF7 for ; Tue, 14 Jun 2016 21:00:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6FFCA160A47; Tue, 14 Jun 2016 19:00:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6BC1160A06 for ; Tue, 14 Jun 2016 21:00:03 +0200 (CEST) Received: (qmail 90962 invoked by uid 500); 14 Jun 2016 19:00:02 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 90951 invoked by uid 99); 14 Jun 2016 19:00:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jun 2016 19:00:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 44B3CC028E for ; Tue, 14 Jun 2016 19:00:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xZ8UVeOFWLNO for ; Tue, 14 Jun 2016 18:59:59 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4C2325F341 for ; Tue, 14 Jun 2016 18:59:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u5EIxw4K032308; Tue, 14 Jun 2016 18:59:58 GMT Message-Id: <201606141859.u5EIxw4K032308@ip-10-146-233-104.ec2.internal> Date: Tue, 14 Jun 2016 18:59:58 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Michael Ho Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3611=3A_track_unused_Disk_IO_buffer_memory=0A?= X-Gerrit-Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 X-Gerrit-ChangeURL: X-Gerrit-Commit: d96d450194118ea6dc5f52cb5abd6a512fdf235a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 14 Jun 2016 19:00:04 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3246/6/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: PS6, Line 859: d, we should be able to remove the free lists > Just checking my understanding here since you claimed in an earlier reply t If I claimed that I didn't mean to. I looked at using TryConsume() in DiskIoMgr::ReturnFreeBuffer(), but that wasn't safe to do because of the issue with free_buffers_lock_. http://gerrit.cloudera.org:8080/#/c/3246/7/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: PS7, Line 749: L > Isn't long 32-bit according to the standard ? I thought we need LL, no ? On Linux and Mac OS X long is the machine word size. Maybe you're thinking of Windows? I'll switch to LL since that is more obviously correct. -- To view, visit http://gerrit.cloudera.org:8080/3246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8777cf76f04d34a46f53d53005412e0f1d63b5b7 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes