Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3A8B8200AF7 for ; Tue, 14 Jun 2016 19:26:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1AAC9160A47; Tue, 14 Jun 2016 17:26:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 61C22160A06 for ; Tue, 14 Jun 2016 19:26:57 +0200 (CEST) Received: (qmail 50555 invoked by uid 500); 14 Jun 2016 17:26:56 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 50537 invoked by uid 99); 14 Jun 2016 17:26:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jun 2016 17:26:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F0FE51A0319 for ; Tue, 14 Jun 2016 17:26:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Xv0_aGSxyDW4 for ; Tue, 14 Jun 2016 17:26:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id DC41E5F253 for ; Tue, 14 Jun 2016 17:26:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u5EHQk3a028394; Tue, 14 Jun 2016 17:26:46 GMT Message-Id: <201606141726.u5EHQk3a028394@ip-10-146-233-104.ec2.internal> Date: Tue, 14 Jun 2016 17:26:46 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Sailesh Mukil Reply-To: henry@cloudera.com X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3682=3A_Don=27t_retry_unrecoverable_socket_creation_errors=0A?= X-Gerrit-Change-Id: I394be287143eefc79cf22865898b71ca24c41328 X-Gerrit-ChangeURL: X-Gerrit-Commit: 65354c5b200c825105c333ad0b0a6529399c8e45 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 14 Jun 2016 17:26:58 -0000 Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-3682: Don't retry unrecoverable socket creation errors ...................................................................... IMPALA-3682: Don't retry unrecoverable socket creation errors If a thrift client can't create a socket, all subsequent calls to Open() should fail fast since socket creation errors are treated as unrecoverable. Testing: manual testing with a bad SSL configuration. Impalad startup fails fast, rather than retrying 10 times as previously. Change-Id: I394be287143eefc79cf22865898b71ca24c41328 Reviewed-on: http://gerrit.cloudera.org:8080/3317 Reviewed-by: Dan Hecht Tested-by: Henry Robinson --- M be/src/rpc/thrift-client.cc M be/src/rpc/thrift-server-test.cc M be/src/runtime/exec-env.cc M common/thrift/generate_error_codes.py 4 files changed, 56 insertions(+), 19 deletions(-) Approvals: Henry Robinson: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I394be287143eefc79cf22865898b71ca24c41328 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Sailesh Mukil