Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5164B200B32 for ; Thu, 9 Jun 2016 06:38:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4FBD3160A35; Thu, 9 Jun 2016 04:38:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 97344160A2E for ; Thu, 9 Jun 2016 06:38:55 +0200 (CEST) Received: (qmail 93798 invoked by uid 500); 9 Jun 2016 04:38:54 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 93787 invoked by uid 99); 9 Jun 2016 04:38:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 04:38:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 04C98180592 for ; Thu, 9 Jun 2016 04:38:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fKV2xuUPINCR for ; Thu, 9 Jun 2016 04:38:52 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id B6C595FACD for ; Thu, 9 Jun 2016 04:38:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u594coGD002806; Thu, 9 Jun 2016 04:38:50 GMT Message-Id: <201606090438.u594coGD002806@ip-10-146-233-104.ec2.internal> Date: Thu, 9 Jun 2016 04:38:50 +0000 From: "Huaisi Xu (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Dan Hecht , Henry Robinson Reply-To: hxu@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-3499=3A_Split_catalog_update=0A?= X-Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 X-Gerrit-ChangeURL: X-Gerrit-Commit: a3536019dc3fd6aa784d8ffec6c87ea69da290ac In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 09 Jun 2016 04:38:56 -0000 Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Split catalog update ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3067/9/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java: PS9, Line 168: req.getUpdated_objects() == null > isSetUpdated_objects() returns boolean (see TUpdateCatalogCacheRequest.java oh. I missed the method.. only saw the "!".. :-( -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Huaisi Xu Gerrit-HasComments: Yes