Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8FB4D200B17 for ; Tue, 7 Jun 2016 00:08:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8E609160A55; Mon, 6 Jun 2016 22:08:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D373E160A24 for ; Tue, 7 Jun 2016 00:08:56 +0200 (CEST) Received: (qmail 47626 invoked by uid 500); 6 Jun 2016 22:08:55 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 47304 invoked by uid 99); 6 Jun 2016 22:08:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jun 2016 22:08:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DAFB3C0EB4 for ; Mon, 6 Jun 2016 22:08:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id M9y5n6nqO5_L for ; Mon, 6 Jun 2016 22:08:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D38105FB12 for ; Mon, 6 Jun 2016 22:08:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u56M8p0m007937; Mon, 6 Jun 2016 22:08:51 GMT Message-Id: <201606062208.u56M8p0m007937@ip-10-146-233-104.ec2.internal> Date: Mon, 6 Jun 2016 22:08:51 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-CR=5D=28cdh5-trunk=29_IMPALA-1619=3A_Support_64-bit_allocations=2E=0A?= X-Gerrit-Change-Id: I7ed28083d809a86d801a9c063a0aa32c50d32b20 X-Gerrit-ChangeURL: X-Gerrit-Commit: e563675cf510b28228188b89ba938b7c8b6fab31 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 06 Jun 2016 22:08:57 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. ...................................................................... Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/2781/5/be/src/runtime/buffered-block-mgr.cc File be/src/runtime/buffered-block-mgr.cc: Line 306: int64_t buffers_needed = BitUtil::Ceil(size, max_block_size()); > Done. I wonder if we available_buffers() should return int instead of int64 I think so, I can't imagine a scenario in which we have 2 billion+ 8mb buffers. -- To view, visit http://gerrit.cloudera.org:8080/2781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ed28083d809a86d801a9c063a0aa32c50d32b20 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes