Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C522F200B13 for ; Wed, 1 Jun 2016 02:37:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C368B160A46; Wed, 1 Jun 2016 00:37:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 179A3160A44 for ; Wed, 1 Jun 2016 02:37:25 +0200 (CEST) Received: (qmail 38347 invoked by uid 500); 1 Jun 2016 00:37:25 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 38336 invoked by uid 99); 1 Jun 2016 00:37:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2016 00:37:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AB786C14B1 for ; Wed, 1 Jun 2016 00:37:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7Wj2lj1CQYud for ; Wed, 1 Jun 2016 00:37:22 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 134035F252 for ; Wed, 1 Jun 2016 00:37:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u510bKHa027106; Wed, 1 Jun 2016 00:37:20 GMT Message-Id: <201606010037.u510bKHa027106@ip-10-146-233-104.ec2.internal> Date: Wed, 1 Jun 2016 00:37:20 +0000 From: "Henry Robinson (Code Review)" To: Huaisi Xu , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Tim Armstrong , Dan Hecht Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3499:_Batch_update_catalog_cache_update.=0A?= X-Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 X-Gerrit-ChangeURL: X-Gerrit-Commit: babaa40fe549d6736c4286e0abf5acffec36272a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Wed, 01 Jun 2016 00:37:26 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-3499: Batch update catalog cache update. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3067/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1312: } > what happens if the total update size (across all entries) is smaller than Oh is that what line 1355 is for? It's a bit confusing for the logic to be all the way down there. Why not move it after this loop? -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Huaisi Xu Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes