impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3800: Python 2.6 support for collect minidumps.py
Date Tue, 28 Jun 2016 21:16:04 GMT
Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3525

Change subject: IMPALA-3800: Python 2.6 support for collect_minidumps.py
......................................................................

IMPALA-3800: Python 2.6 support for collect_minidumps.py

Python 2.6 is the default python version shipped with CentOS 6.6 and
the minidump collection script needs to run there, too. However, the
tarfile library version shipped with python 2.6 does not support using
TarFile objects as context managers. This change wraps the usage of
tarfile.TarFile in contextlib.closing to support python 2.6, too.

Testing: I verified that this script runs with python 2.7 on testdata
generated using the generate_minidump_collection_testdata.py script. I
also copied an updated version to a CentOS 6.6 cluster and verified that
the problem is resolved there.

Change-Id: Ic9028626fa829ff7571d2a731c2fcd7e15e2ce36
---
M bin/collect_minidumps.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/25/3525/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9028626fa829ff7571d2a731c2fcd7e15e2ce36
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker <lv@cloudera.com>

Mime
View raw message