impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3757: Add missing lock in RuntimeProfile::ComputeTimeInProfile
Date Fri, 17 Jun 2016 01:35:01 GMT
Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3397

Change subject: IMPALA-3757: Add missing lock in RuntimeProfile::ComputeTimeInProfile
......................................................................

IMPALA-3757: Add missing lock in RuntimeProfile::ComputeTimeInProfile

We've seen a number of issues that appear to be a race
around the RuntimeProfile handling on the coordinator. We
don't have a consistent repro and haven't been able to find
the root cause of the crashes/hangs, but we have seen a
number of stacks from crashes that include the following
frames:

...
RuntimeProfile::ComputeTimeInProfile
RuntimeProfile::UpdateAverage
Coordinator::UpdateAverageProfile
Coordinator::UpdateFragmentExecStatus
...

This patch fixes a case where we iterate over children_
without holding the lock. I can't prove that this causes the
hangs but we certainly should fix this regardless.

Change-Id: Ibb40ebfa2e58ecaa8668d30ad92003fc75483517
---
M be/src/util/runtime-profile.cc
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/97/3397/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb40ebfa2e58ecaa8668d30ad92003fc75483517
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message