impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test catalog service client.py.
Date Fri, 10 Jun 2016 21:39:03 GMT
David Knupp has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3366

Change subject: IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
......................................................................

IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.

Even though this is just a single test, this change introduces the
unique_database test fixture that was initially created to help with
concurrent tests. It's still worth to do this here because we want to
update all tests to use best practices.

That said, there was still a performance gain to be had here. It
turns out the initial code called the cleanup_db() method from the
base ImpalaTestSuite class, which in turn sets the 'sync_ddl' query
option to true. Not doing this at the beginning of this test results
in a roughly 40x speedup.

Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
---
M tests/catalog_service/test_catalog_service_client.py
1 file changed, 11 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/66/3366/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <dknupp@cloudera.com>

Mime
View raw message