impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Armstrong <tarmstr...@cloudera.com>
Subject Re: [Impala-CR](cdh5-trunk) IMPALA-3441: check for malformed Avro data
Date Thu, 02 Jun 2016 03:46:39 GMT
Replying by email since gerrit is down.

Feel free to skip those remaining suggestions if they don't look
worthwhile, especially the data_end one.

It looks like ReadZLong isn't cross-compiled, so presumably we'd see that
show up in the profile, no?

If you start up impala with --perf_map=true you will get function-level
symbols for codegened code, which may be somewhat helpful, but nowhere near
as useful as line-level since everything is inlined. It's a little more
helpful combined with other perf counters e.g. "perf top -e branch-misses"




On Wed, Jun 1, 2016 at 8:02 PM, Dan Hecht (Code Review) <gerrit@cloudera.org
> wrote:

> Dan Hecht has posted comments on this change.
>
> Change subject: IMPALA-3441: check for malformed Avro data
> ......................................................................
>
>
> Patch Set 6:
>
> I think Tim checked in the changes to get 'perf' support for codegen code
> working.  You can check with him about that.
>
> --
> To view, visit http://gerrit.cloudera.org:8080/3072
> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I801a11c496a128e02c564c2a9c44baa5a97be132
> Gerrit-PatchSet: 6
> Gerrit-Project: Impala
> Gerrit-Branch: cdh5-trunk
> Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
> Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
> Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
> Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
> Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
> Gerrit-HasComments: No
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message