impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads
Date Wed, 29 Jun 2016 16:24:22 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3313/8/tests/query_test/test_hdfs_caching.py
File tests/query_test/test_hdfs_caching.py:

PS8, Line 101:     if self.exploration_strategy() != 'exhaustive': pytest.skip()
Unfortunately this means this test won't ever be run, because the workload is not set to functional-query,
and for historical reasons not clear to me, the way we call impala-py.test is only to set
the workload exploration strategy of the functional-query workload (see bin/run-all-tests.sh,
L89-90).


PS8, Line 121:       while not is_path_fully_cached(encrypted_table_dir): time.sleep(2)
What about a max timeout here so we don't loop indefinitely?


-- 
To view, visit http://gerrit.cloudera.org:8080/3313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a9ea19dd8571b01d2cd5b87da1c259219f6297a
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message